-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: firefox addon limitations #575
Conversation
WalkthroughThe pull request introduces several changes to enhance the build process for an Opera browser extension within a GitHub Actions workflow. Key modifications include the addition of steps to build and package the extension, updates to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
💼 Build Files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
packages/extension/vite.config.ts (2)
16-22
: Good addition: Firefox-specific chunk optimizationThe
firefoxChunking
function implements a smart strategy for managing node_modules chunks in Firefox builds. This could help with Firefox's addon size limitations and improve load-time performance.Consider adding a comment explaining the rationale behind this Firefox-specific chunking strategy.
+// Firefox-specific chunking strategy to optimize addon size and improve load-time performance const firefoxChunking = (id: string) => {
3-4
: Good addition: Bundle visualization supportThe addition of the visualizer plugin will help monitor and optimize chunk sizes, which is particularly valuable for debugging Firefox addon size limitations.
Consider documenting the location of the generated visualization report in the README to help other developers monitor bundle sizes.
Also applies to: 59-59
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
📒 Files selected for processing (7)
.github/workflows/release.yml
(1 hunks)packages/extension/.gitignore
(1 hunks)packages/extension/configs/vite/assets-rewrite.ts
(1 hunks)packages/extension/package.json
(2 hunks)packages/extension/src/manifest/manifest.firefox.ts
(1 hunks)packages/extension/src/ui/provider-pages/main.ts
(1 hunks)packages/extension/vite.config.ts
(4 hunks)
✅ Files skipped from review due to trivial changes (4)
- packages/extension/.gitignore
- packages/extension/configs/vite/assets-rewrite.ts
- packages/extension/package.json
- packages/extension/src/ui/provider-pages/main.ts
🔇 Additional comments (3)
packages/extension/src/manifest/manifest.firefox.ts (1)
24-24
: LGTM: Extension ID added
The addition of a fixed extension ID is good practice for Firefox addons. This ensures consistent identification across updates and installations.
.github/workflows/release.yml (1)
48-49
: LGTM: Opera build steps added
The Opera build steps are well-structured and follow the same pattern as other browser builds. The file naming convention is consistent with existing artifacts.
packages/extension/vite.config.ts (1)
106-108
: LGTM: Conditional chunk management
The conditional application of Firefox chunking strategy is well-implemented. This ensures Firefox builds get optimized chunking while maintaining default behavior for other browsers.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
.gitignore
to excludestats.html
.Style
Chores