Fix: Rango supported network check

[NickKelly1]

Fixes a bug where Rango doesn't exit early if a network is not supported.

Summary by CodeRabbit

• New Features

  • Enhanced error handling for unsupported source or destination networks in the swap functionality.
  • Improved debug logging for the swap process, providing better insights into network and token states.

• Bug Fixes

  • Refined error handling for Rango swap responses, ensuring appropriate logging and returning null in case of issues.

• Tests

  • Standardized formatting and descriptions in the Zerox provider test suite for consistency.

[coderabbitai]

Walkthrough

The changes involve modifications to the Rango class within the packages/swap/src/providers/rango/index.ts file, focusing on enhancing error handling and logging in the getRangoSwap method. The method now returns null for unsupported networks and includes detailed debug logging. Additionally, the test suite for the Zerox provider in packages/swap/tests/zerox.test.ts has been updated for consistency in test case descriptions and formatting, while maintaining the original test logic and assertions.

Changes

File Path	Change Summary
packages/swap/src/providers/rango/index.ts	Enhanced error handling and debug logging in getRangoSwap method; returns null for unsupported networks. Clarified logging in the init method.
packages/swap/tests/zerox.test.ts	Updated test case descriptions for consistency; standardized formatting without altering test logic.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 76fb11b and f851dde.

📒 Files selected for processing (2)

• packages/swap/src/providers/rango/index.ts (2 hunks)
• packages/swap/tests/zerox.test.ts (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• packages/swap/tests/zerox.test.ts

🔇 Additional comments (2)

packages/swap/src/providers/rango/index.ts (2)

632-632: LGTM: Early exits for unsupported networks

The added early returns improve error handling by exiting immediately when either source or destination networks are unsupported. This prevents unnecessary processing and potential errors downstream, aligning with the PR objective to fix Rango supported network checks.

Also applies to: 646-646

---

Line range hint 1005-1039: Verify network mapping completeness

While the network support validation is comprehensive, let's verify that all supported networks are properly mapped to avoid potential issues.

✅ Verification successful

Network mappings are complete

All supported networks are properly mapped with no duplicates found.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify network mapping completeness by checking:
# 1. All supported networks have corresponding Rango blockchain mappings
# 2. No duplicate chain IDs or blockchain names

# Search for network definitions and mappings
rg -A 5 'SupportedNetworkName\.' | grep -v 'case'

# Search for potential unmapped networks
ast-grep --pattern 'SupportedNetworkName.$_' 

Length of output: 60880

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

💼 Build Files
chrome: enkrypt-chrome-f851ddef.zip
firefox: enkrypt-firefox-f851ddef.zip

💉 Virus total analysis
chrome: f851ddef
firefox: f851ddef