litespi: fix cs handling for bulk transfers #852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For bulk transfers it is essential to keep cs asserted for all transfers in a block. CS register must directly drive the cs pin for the software to be able to control the CS pin.
mczerski
force-pushed
the
litespi_cs_handling
branch
from
058e6a9
to
8bddc16
Compare
|
Thanks @mczerski, I'll have a closer look at it in the next days. |
|
Sorry for the delay @mczerski, unfortunately, we can't merge the change since it would break several external design that are not using bulk transfers, so we have to keep things retro-compatible. With 8ce7c58, things are kept compatible and a new manual mode is added for CS, where CS will be a direct recopy of the CS set in the CSR: https://github.com/enjoy-digital/litex/blob/master/litex/soc/cores/spi.py#L175 This can be used for bulk transfers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For bulk transfers it is essential to keep cs asserted for all
transfers in a block. CS register must directly drive the cs pin
for the software to be able to control the CS pin.
Linux driver related changes are in litex-hub/linux#4.