efinix: gpio: use constant output option #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
share common code for INPUT, INOUT and OUTPUT. Signed-off-by: Fin Maaß <[email protected]>
fix in OUTPUT Signed-off-by: Fin Maaß <[email protected]>
check wraped signals instead of before. Signed-off-by: Fin Maaß <[email protected]>
maass-hamburg
changed the title
use constant output option, when the output is a `Constant` Signed-off-by: Fin Maaß <[email protected]>
maass-hamburg
force-pushed
the
efinix_io_optimize
branch
from
e3988af
to
54973eb
Compare
|
@enjoy-digital you might want to take a look. This improves open drain IOs, which are used for I2C. It also does some cleanup in the efinix ifacewriter |
|
@enjoy-digital what do you think? |
enjoy-digital
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Thanks @maass-hamburg and sorry for the delay, this looks good and that's nice you see you managed to share common code for Input/Output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use constant output option, when the output is a
ConstantSigned-off-by: Fin Maaß [email protected]