-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: image filtering #441
base: main
Are you sure you want to change the base?
Conversation
@paullaffitte Thanks for the documentation. I understand the order is similar to:
In practice, I want to only cache docker.io images, I should use the following:
Is that correct? |
Almost, with the current |
@paullaffitte Indeed, thanks. How would you configure to only cache docker.io ones? In my understanding this needs currently explicit denial of the other patterns or namespace. |
humm.. maybe I should add an example to the doc. I feel like it is not that easy to explain even though it is not very complicated. Something like: Given a list of images and a image filtering configuration:
controllers:
webhook:
ignoredImages:
- "^.+:[\\w-]*alpine[\\w-]*$"
acceptedImages:
- "^docker\\.io/.*" Performing the "ignore" step will remove the matching In the case of an empty |
@paullaffitte Your explanations are clear. Can you precise how objectSelector.matchExpressions enter the mix? Support for negating in the regex would also be beneficial, currently not supported. |
From the documentation:
Why do you want to negate in the regex? You already can already do it by using either |
What do you think @zifeo? Is it clearer?
closes #440