Fix serious building issues due to merging without passing CI 😅 #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertBColton
approved these changes
Aug 13, 2024
Signed-off-by: Saif Kandil <[email protected]>
Signed-off-by: Saif Kandil <[email protected]>
…install manually Signed-off-by: Saif Kandil <[email protected]>
Signed-off-by: Saif Kandil <[email protected]>
Co-authored-by: Robert Colton <[email protected]>
Signed-off-by: Saif Kandil <[email protected]>
k0T0z
commented
Aug 19, 2024
| @@ -116,7 +116,8 @@ RoomEditor::RoomEditor(MessageModel* model, QWidget* parent) : BaseEditor(model, | |||
|
|
|||
| // This updates all the model views in the event of a sprite is changed | |||
| connect(MainWindow::resourceMap, &ResourceModelMap::DataChanged, this, [this]() { | |||
| _ui->entitiesListView->reset(); | |||
| // _ui->entitiesListView->reset(); | |||
| _ui->elementsListView->reset(); | |||
There was a problem hiding this comment.
@RobertBColton There is no entitiesListView in the ui file, I found elementsListView instead.
Signed-off-by: Saif Kandil <[email protected]>
Signed-off-by: Saif Kandil <[email protected]>
Signed-off-by: Saif Kandil <[email protected]>
Signed-off-by: Saif Kandil <[email protected]>
Signed-off-by: Saif Kandil <[email protected]>
Signed-off-by: Saif Kandil <[email protected]>
Signed-off-by: Saif Kandil <[email protected]>
4 tasks
Signed-off-by: Saif Kandil <[email protected]>
Signed-off-by: Saif Kandil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @RobertBColton,
Here are the changes that solve all building problems, now, RGM can be built without problems.
This PR won't work without the changes in enigma-dev/enigma-dev#2399.
Fixed:
findcommand.nodeeditordependency in the build system and as a submodule for Procedural Fragment Shader Generation Using Classic Machine Learning enigma-dev#2390.emakedoesn't able to launch usingQProcess.