Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MIRAI diagnostic message easier to identify #24

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Make MIRAI diagnostic message easier to identify #24

merged 2 commits into from
Dec 16, 2024

Conversation

seanrion
Copy link
Contributor

@seanrion seanrion commented Dec 14, 2024 •
edited
Loading

Description

Related to #23

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • API change with a documentation update
  • Additional test coverage
  • Code cleanup or just keeping up with the latest Rustc nightly

How Has This Been Tested?

Checklist:

  • Fork the repo and create your branch from main.
  • If you've added code that should be tested, add tests.
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes.
  • Make sure your code lints.

@hermanventer
Copy link
Collaborator

Please add a test plan to your summary.

@seanrion
Copy link
Contributor Author

Sorry for submitting a pr without testing, now on my Ubuntu 22.04.4 LTS has passed all tests except call graph test.

@hermanventer hermanventer merged commit 0baad63 into endorlabs:main Dec 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanrion @hermanventer