feat(captp): handle send rejections
#2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
approved these changes
Aug 23, 2024
michaelfig
force-pushed
the
mfig-2412-rejected-send
branch
from
2db2d37 to
6115cb1
Compare
michaelfig
force-pushed
the
mfig-2412-rejected-send
branch
2 times, most recently
from
6817b65 to
418df3f
Compare
michaelfig
force-pushed
the
mfig-2412-rejected-send
branch
from
418df3f to
7201ae4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2412
Description
Have CapTP abort the connection if
sendreturns a promise rejection. The existing implementation only aborted ifsendthrew a synchronous exception.Security Considerations
Crisper handling of async transport-layer failures.
Scaling Considerations
n/a
Documentation Considerations
Allows effective use of
asyncCapTP send functions.Testing Considerations
Usual CI.
Compatibility Considerations
Will abort the connection if an
asyncsendrejects. Before, the rejection was ignored.Upgrade Considerations
n/a