Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Delete obsolete platform-compatibility-test #2419

Merged
merged 1 commit into from
Aug 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 0 additions & 51 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -231,57 +231,6 @@ jobs:
- name: Run yarn test262
run: exit 0 # TODO remove test262 from required tests for CI

platform-compatibility-test:
name: platform-compatibility-test

# begin macro

runs-on: ${{ matrix.platform }}
strategy:
fail-fast: false
matrix:
node-version: [18.x, 20.x]
platform: [ubuntu-latest]

steps:
- name: Checkout
uses: actions/checkout@v3

# without this, setup-node errors on mismatched yarn versions
- run: corepack enable

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
cache: yarn

- name: Echo node version
run: node --version

- name: Install dependencies
run: yarn install --immutable

# end macro

- name: 'build'
run: yarn run build

# fails under Node v12
- run: corepack disable

- name: 'switch to node v12'
uses: actions/setup-node@v3
with:
node-version: '12.x'

- name: Echo node version
run: node --version

- name: Run test:platform-compatibility
# npm b/c Yarn 4 doesn't work in Node 12
run: cd packages/ses && npm run test:platform-compatibility

viable-release:
name: viable-release

Expand Down
3 changes: 1 addition & 2 deletions packages/ses/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@
"lint:types": "tsc",
"prepare": "npm run clean && npm run build",
"qt": "ava",
"test": "tsd && ava",
"test:platform-compatibility": "node test/package/test.cjs"
"test": "tsd && ava"
},
"dependencies": {
"@endo/env-options": "workspace:^"
Expand Down
Loading