support destructuring in harden-exports #2404
Draft
+92
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
approved these changes
Dec 6, 2024
Comment on lines
+57
to
+64
| if (prop.value.type === 'Identifier') { | ||
| exportNames.push(prop.value.name); | ||
| } else if ( | ||
| prop.value.type === 'AssignmentPattern' && | ||
| prop.value.left.type === 'Identifier' | ||
| ) { | ||
| exportNames.push(prop.value.left.name); | ||
| } |
There was a problem hiding this comment.
This is missing the recursive case in which prop.value.type is itself an ObjectPattern or ArrayPattern (e.g., export const { wrapper: { propName } } = objWithWrapper; and export const [{ wrapper: { propName: exportName } }] = [objWithWrapper];). That was true before as well, but if we're making changes anyway then we ought to fix the gap.
(and likewise for the elements of an ArrayPattern below)
Comment on lines
+99
to
+117
| ((statement.expression.arguments[0].type === 'Identifier' && | ||
| statement.expression.arguments[0].name === exportName) || | ||
| // @ts-expect-error XXX non-overlapping | ||
| (statement.expression.arguments[0].type === 'ObjectPattern' && | ||
| // @ts-expect-error XXX non-overlapping | ||
| statement.expression.arguments[0].properties.some( | ||
| prop => | ||
| prop.value.type === 'Identifier' && | ||
| prop.value.name === exportName, | ||
| )) || | ||
| // @ts-expect-error XXX non-overlapping | ||
| (statement.expression.arguments[0].type === 'ArrayPattern' && | ||
| // @ts-expect-error XXX non-overlapping | ||
| statement.expression.arguments[0].elements.some( | ||
| element => | ||
| element && | ||
| element.type === 'Identifier' && | ||
| element.name === exportName, | ||
| ))), |
There was a problem hiding this comment.
This whole block could really use some commentary/substructure/etc.
|
I agree with @gibson042's comments. I would like to see them addressed before I can approve or offer more suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXXX
Refs: #XXXX
Description
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Compatibility Considerations
Upgrade Considerations