Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): ScalarKey #2273

Merged
merged 1 commit into from
May 7, 2024
Merged

feat(types): ScalarKey #2273

merged 1 commit into from
May 7, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented May 7, 2024

Description

ScalarKey is a patterns concept but without a typedef. This defines it.

Necessary for Agoric/agoric-sdk#8774 (review)

Security Considerations

no

Scaling Considerations

no

Documentation Considerations

no

Testing Considerations

new tests

Compatibility Considerations

no

Upgrade Considerations

no

@turadg turadg requested review from dckc and erights May 7, 2024 17:51
Copy link
Contributor

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. On target.

@turadg turadg force-pushed the ta/types-scalarKey branch from b7807ff to a02734a Compare May 7, 2024 18:08
@turadg turadg enabled auto-merge May 7, 2024 18:11
@turadg turadg merged commit 79c43e7 into master May 7, 2024
17 checks passed
@turadg turadg deleted the ta/types-scalarKey branch May 7, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants