fix type imports in 'marshal' package #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Thanks for fixing this.
Should the relaxation mentioned in #1928 (comment) be addressed in this PR?
turadg
force-pushed
the
ta/type-imports
branch
from
5f38eeb to
0c3dc62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a recent review it came up that type imports to
@endo/marshalwere coming through asany. #1928 (comment)The cause was that the
maxNodeModuleJsDepthwas 0, the default for tsconfig.json (as opposed to 2 for jsconfig.json). This bumps it to 1 to get the types from @endo/pass-style.It also adds a regression test, which failed before the change.
As a bit of housekeeping it also bumps some typescript deps and refreshes the coverage report.
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations