fix: sync with shadows in agoric-sdk #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warner
reviewed
Apr 1, 2023
erights
force-pushed
the
markm-resync-agoric-sdk
branch
from
faffedc to
b22b053
Compare
erights
force-pushed
the
markm-resync-agoric-sdk
branch
from
b22b053 to
b9beeef
Compare
turadg
approved these changes
Apr 3, 2023
dckc
reviewed
Apr 3, 2023
erights
force-pushed
the
markm-resync-agoric-sdk
branch
from
65e3a5e to
19e2833
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some code from the
@agoric/storepackage was unbundled and migrated to the@endo/patternsand@endo/exopackages. However, until agoric-sdk is upgraded to depend on the endo with these migrated packages, it continues to use its own deprecated copies, which we be removed after this upgrade happens. To smooth the way for this, we try to keep the code in these packages in sync with their shadows in agoric-sdk.However, since the last sync there has been version drift. This PR brings them back into alignment.
As verified by #1533 , this PR is independent of #1531 , and can proceed without interference.