WIP: Event-based encoding API based on Data-E #1423
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-data-jessie
branch
4 times, most recently
from
8fbd823 to
750e586
Compare
erights
force-pushed
the
markm-data-jessie
branch
from
750e586 to
6a0cd77
Compare
erights
force-pushed
the
markm-data-jessie
branch
5 times, most recently
from
1633a1f to
15b3d4f
Compare
erights
force-pushed
the
markm-data-jessie
branch
from
15b3d4f to
207e2eb
Compare
erights
changed the base branch from
master
to
gibson-1349-encodepassable-escaping
erights
force-pushed
the
markm-data-jessie
branch
from
207e2eb to
a2944f1
Compare
erights
changed the base branch from
gibson-1349-encodepassable-escaping
to
master
erights
force-pushed
the
markm-data-jessie
branch
4 times, most recently
from
d70ff81 to
9f683f0
Compare
erights
force-pushed
the
markm-data-jessie
branch
2 times, most recently
from
95ec395 to
c6b75e3
Compare
erights
force-pushed
the
markm-data-jessie
branch
3 times, most recently
from
810485d to
6e49597
Compare
erights
force-pushed
the
markm-data-jessie
branch
2 times, most recently
from
b249fc1 to
a9f7a02
Compare
3 tasks
erights
force-pushed
the
markm-data-jessie
branch
from
b3e8267 to
0d9c977
Compare
erights
force-pushed
the
markm-data-jessie
branch
2 times, most recently
from
a5b2f9c to
fcca76a
Compare
erights
force-pushed
the
markm-data-jessie
branch
4 times, most recently
from
41698a9 to
f8ed0f8
Compare
erights
force-pushed
the
markm-data-jessie
branch
2 times, most recently
from
45b19b2 to
6b658fb
Compare
erights
force-pushed
the
markm-data-jessie
branch
2 times, most recently
from
29f3d96 to
f4d9222
Compare
erights
force-pushed
the
markm-data-jessie
branch
from
f4d9222 to
ac5d745
Compare
erights
force-pushed
the
markm-data-jessie
branch
from
ac5d745 to
185fb06
Compare
erights
force-pushed
the
markm-data-jessie
branch
from
185fb06 to
2e3e068
Compare
erights
force-pushed
the
markm-data-jessie
branch
2 times, most recently
from
5b218d2 to
a835285
Compare
erights
force-pushed
the
markm-data-jessie
branch
from
a835285 to
821f6a9
Compare
erights
force-pushed
the
markm-data-jessie
branch
from
821f6a9 to
63674e8
Compare
erights
force-pushed
the
markm-data-jessie
branch
4 times, most recently
from
4e8e848 to
1c2145f
Compare
erights
force-pushed
the
markm-data-jessie
branch
from
1c2145f to
bcc515b
Compare
erights
force-pushed
the
markm-data-jessie
branch
from
bcc515b to
42d5319
Compare
dckc
reviewed
Mar 29, 2024
Comment on lines
+223
to
+224
| // copyRecord allows only string keys so this will | ||
| // work. |
There was a problem hiding this comment.
copyRecord keys can be symbols now, right?
@gibson042 and I just talked about that recently, I think.
There was a problem hiding this comment.
oh... or is that Far object method names?
There was a problem hiding this comment.
No. Yes.
Cannot be copyRecord property names. Can be Far object method names.
There was a problem hiding this comment.
Though we discourage the latter until we see how receptive OCapN is to @kriskowal 's suggestions to no longer accept symbol method names per se. IOW, only string names transmitted as method names, where each side get to decide whether to translate it into a local string method name or a local symbol method name. Would require a bit of refactoring of abstraction levels, so method names have a special place, and so unlikely to be settled soon. Until then, the current symbols-also consensus stands. But we'd like to avoid unnecessarily entrenching that until this matter is settled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See http://www.erights.org/data/serial/jhu-paper/data-e-manual.html
@kriskowal , an unfortunate result of reminding me of Data-E ;)
@gibson042 , I don't know that I'll ever get it ready for review. But you may be interested anyway.
No longer staged on #1594 until it is on a more recent master