Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: smallcaps, see what breaks #1283

Closed
wants to merge 1 commit into from

Conversation

erights
Copy link
Contributor

@erights erights commented Sep 12, 2022

Starts from #1282 by changing only the default choice from the capData encoding to the smallcaps encoding, in order to see what breaks under CI.

@erights erights requested a review from dtribble September 12, 2022 03:09
@erights erights self-assigned this Sep 12, 2022
@erights erights force-pushed the markm-smallcaps-see-what-breaks branch 2 times, most recently from f2888ea to 35c4735 Compare September 12, 2022 03:47
@erights erights force-pushed the markm-dean-smaller-json branch 2 times, most recently from 92f1e15 to 81126ae Compare September 13, 2022 01:08
@erights erights force-pushed the markm-smallcaps-see-what-breaks branch 6 times, most recently from c551844 to 7c4edc5 Compare September 13, 2022 17:45
@erights erights force-pushed the markm-dean-smaller-json branch from a5de158 to a4f6fe0 Compare September 13, 2022 19:12
@erights erights force-pushed the markm-smallcaps-see-what-breaks branch 2 times, most recently from a73ef37 to f0b6fd8 Compare September 14, 2022 03:45
@erights erights force-pushed the markm-dean-smaller-json branch from 98a31b1 to de9ad19 Compare September 14, 2022 21:34
@erights erights force-pushed the markm-smallcaps-see-what-breaks branch from f0b6fd8 to 8bcd15b Compare September 14, 2022 21:35
@erights erights force-pushed the markm-dean-smaller-json branch from de9ad19 to 0a5739f Compare September 17, 2022 04:55
@erights erights force-pushed the markm-smallcaps-see-what-breaks branch 2 times, most recently from 1642952 to c483eb7 Compare September 19, 2022 01:27
@erights erights force-pushed the markm-dean-smaller-json branch 2 times, most recently from f0e5e87 to ae8d7e6 Compare September 23, 2022 02:39
Base automatically changed from markm-dean-smaller-json to master September 23, 2022 07:35
@erights erights force-pushed the markm-smallcaps-see-what-breaks branch 2 times, most recently from 4fc29bc to 6aa87eb Compare September 27, 2022 00:16
@erights erights force-pushed the markm-smallcaps-see-what-breaks branch from 6aa87eb to e330d04 Compare September 27, 2022 00:25
@erights
Copy link
Contributor Author

erights commented Sep 29, 2022

Closing as this diagnostic is no longer how we'll probe the issue

@erights erights closed this Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant