feat(ses): enablements needed by (old?) mobx (#2030)

endojs · Feb 2, 2024 · 553cb52 · 553cb52
1 parent eebcb54
commit 553cb52
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/packages/ses/src/enablements.js b/packages/ses/src/enablements.js
@@ -1,4 +1,4 @@
-import { toStringTagSymbol } from './commons.js';
+import { toStringTagSymbol, iteratorSymbol } from './commons.js';
 
 /**
  * @file Exports {@code enablements}, a recursively defined
@@ -97,6 +97,8 @@ export const moderateEnablements = {
   '%ArrayPrototype%': {
     toString: true,
     push: true, // set by "Google Analytics"
+    concat: true, // set by mobx generated code (old TS compiler?)
+    [iteratorSymbol]: true, // set by mobx generated code (old TS compiler?)
   },
 
   // Function.prototype has no 'prototype' property to enable.

diff --git a/packages/ses/test/test-enable-property-overrides-default.js b/packages/ses/test/test-enable-property-overrides-default.js
@@ -8,7 +8,7 @@ test('enablePropertyOverrides - on', t => {
   overrideTester(t, 'Object', {}, ['toString', 'valueOf']);
   // We allow 'length' *not* because it is in enablements; it is not;
   // but because each array instance has its own.
-  overrideTester(t, 'Array', [], ['toString', 'length', 'push']);
+  overrideTester(t, 'Array', [], ['toString', 'length', 'push', 'concat']);
   // eslint-disable-next-line func-names, prefer-arrow-callback
   overrideTester(t, 'Function', function () {}, [
     'constructor',

diff --git a/packages/ses/test/test-enable-property-overrides-severe-debug.js b/packages/ses/test/test-enable-property-overrides-severe-debug.js
@@ -16,7 +16,7 @@ test('enablePropertyOverrides - on, with debug', t => {
 
   // We allow 'length' *not* because it is in enablements; it is not;
   // but because each array instance has its own.
-  overrideTester(t, 'Array', [], ['toString', 'length', 'push']);
+  overrideTester(t, 'Array', [], ['toString', 'length', 'push', 'concat']);
 
   const TypedArray = getPrototypeOf(Uint8Array);
   overrideTester(

diff --git a/packages/ses/test/test-enable-property-overrides-severe.js b/packages/ses/test/test-enable-property-overrides-severe.js
@@ -12,7 +12,7 @@ test('enablePropertyOverrides - on', t => {
 
   // We allow 'length' *not* because it is in enablements; it is not;
   // but because each array instance has its own.
-  overrideTester(t, 'Array', [], ['toString', 'length', 'push']);
+  overrideTester(t, 'Array', [], ['toString', 'length', 'push', 'concat']);
 
   const TypedArray = getPrototypeOf(Uint8Array);
   overrideTester(