Merge pull request #1961 from endojs/revert-1933-1488-Passable

Revert "1488 Passable"

packages/captp/src/captp.js

@@ -326,9 +326,8 @@ export const makeCapTP = (
 
   const IS_REMOTE_PUMPKIN = harden({});
   /**
-   * @type {import('@endo/marshal').ConvertValToSlot<import('./types.js').CapTPSlot>}
+   * @type {import('@endo/marshal').ConvertSlotToVal<import('./types.js').CapTPSlot>}
    */
-  // @ts-expect-error intentional hack
   const assertValIsLocal = val => {
     const slot = valToSlot.get(val);
     if (slot && slot[1] === '-') {
@@ -500,7 +499,6 @@ export const makeCapTP = (
     }
 
     // If we imported this slot, mark it as one our peer exported.
-    // @ts-expect-error map lacks value type
     return slotToImported.get(recvSlot.add(slot));
   }
 

packages/exo/tsconfig.json

@@ -1,7 +1,7 @@
 {
   "extends": "../../tsconfig.eslint-base.json",
   "compilerOptions": {
-    "maxNodeModuleJsDepth": 2
+    "maxNodeModuleJsDepth": 1
   },
   "include": [
     "*.js",

packages/far/test/test-marshal-far-obj.js

@@ -66,7 +66,6 @@ const testRecord = ({
     }),
   );
 
-/** @type {import('@endo/pass-style').PassStyled<'remotable'>} */
 const goodRemotableProto = testRecord();
 
 // @ts-ignore We're testing bad things anyway
@@ -130,7 +129,6 @@ test('passStyleOf validation of remotables', t => {
   t.throws(() => passStyleOf(badRemotableProto3), NON_METHOD);
   t.throws(() => passStyleOf(badRemotableProto4), NON_METHOD);
 
-  // @ts-expect-error UNTIL https://github.com/microsoft/TypeScript/issues/38385
   t.is(passStyleOf(sub(goodRemotableProto)), 'remotable');
 
   t.throws(() => passStyleOf(sub(badRemotableProto1)), EXPECTED_PASS_STYLE);

packages/marshal/src/deeplyFulfilled.js

@@ -51,22 +51,18 @@ export const deeplyFulfilled = async val => {
   const passStyle = passStyleOf(val);
   switch (passStyle) {
     case 'copyRecord': {
-      // @ts-expect-error FIXME narrowed
       const names = ownKeys(val);
       const valPs = names.map(name => deeplyFulfilled(val[name]));
       return E.when(Promise.all(valPs), vals =>
         harden(fromEntries(vals.map((c, i) => [names[i], c]))),
       );
     }
     case 'copyArray': {
-      // @ts-expect-error FIXME narrowed
       const valPs = val.map(p => deeplyFulfilled(p));
       return E.when(Promise.all(valPs), vals => harden(vals));
     }
     case 'tagged': {
-      // @ts-expect-error FIXME narrowed
       const tag = getTag(val);
-      // @ts-expect-error FIXME narrowed
       return E.when(deeplyFulfilled(val.payload), payload =>
         makeTagged(tag, payload),
       );

packages/marshal/src/encodePassable.js

@@ -27,7 +27,7 @@ const { ownKeys } = Reflect;
  * string-named own properties. `recordNames` returns those name *reverse*
  * sorted, because that's how records are compared, encoded, and sorted.
  *
- * @template {Passable} T
+ * @template T
  * @param {CopyRecord<T>} record
  * @returns {string[]}
  */
@@ -44,7 +44,7 @@ harden(recordNames);
  * Assuming that `record` is a CopyRecord and `names` is `recordNames(record)`,
  * return the corresponding array of property values.
  *
- * @template {Passable} T
+ * @template T
  * @param {CopyRecord<T>} record
  * @param {string[]} names
  * @returns {T[]}

packages/marshal/src/encodeToCapData.js

@@ -20,7 +20,7 @@ import {
 
 /** @typedef {import('@endo/pass-style').Passable} Passable */
 /** @typedef {import('./types.js').Encoding} Encoding */
-/** @typedef {import('@endo/pass-style').RemotableObject} RemotableObject */
+/** @typedef {import('@endo/pass-style').Remotable} Remotable */
 /** @typedef {import('./types.js').EncodingUnion} EncodingUnion */
 
 const { ownKeys } = Reflect;
@@ -62,7 +62,7 @@ const qclassMatches = (encoded, qclass) =>
 /**
  * @typedef {object} EncodeToCapDataOptions
  * @property {(
- *   remotable: RemotableObject,
+ *   remotable: Remotable,
  *   encodeRecur: (p: Passable) => Encoding
  * ) => Encoding} [encodeRemotableToCapData]
  * @property {(
@@ -117,7 +117,7 @@ export const makeEncodeToCapData = (encodeOptions = {}) => {
    * Readers must not care about this order anyway. We impose this requirement
    * mainly to reduce non-determinism exposed outside a vat.
    *
-   * @param {any} passable
+   * @param {Passable} passable
    * @returns {Encoding} except that `encodeToCapData` does not generally
    * `harden` this result before returning. Rather, `encodeToCapData` is not
    * directly exposed.
@@ -269,11 +269,11 @@ harden(makeEncodeToCapData);
  * @property {(
  *   encodedRemotable: Encoding,
  *   decodeRecur: (e: Encoding) => Passable
- * ) => (Promise|RemotableObject)} [decodeRemotableFromCapData]
+ * ) => (Promise|Remotable)} [decodeRemotableFromCapData]
  * @property {(
  *   encodedPromise: Encoding,
  *   decodeRecur: (e: Encoding) => Passable
- * ) => (Promise|RemotableObject)} [decodePromiseFromCapData]
+ * ) => (Promise|Remotable)} [decodePromiseFromCapData]
  * @property {(
  *   encodedError: Encoding,
  *   decodeRecur: (e: Encoding) => Passable

packages/marshal/src/encodeToSmallcaps.js

@@ -18,7 +18,7 @@ import {
 } from '@endo/pass-style';
 
 /** @typedef {import('@endo/pass-style').Passable} Passable */
-/** @typedef {import('@endo/pass-style').RemotableObject} Remotable */
+/** @typedef {import('@endo/pass-style').Remotable} Remotable */
 // @typedef {import('./types.js').SmallcapsEncoding} SmallcapsEncoding */
 // @typedef {import('./types.js').SmallcapsEncodingUnion} SmallcapsEncodingUnion */
 /** @typedef {any} SmallcapsEncoding */
@@ -161,7 +161,7 @@ export const makeEncodeToSmallcaps = (encodeOptions = {}) => {
    * Readers must not care about this order anyway. We impose this requirement
    * mainly to reduce non-determinism exposed outside a vat.
    *
-   * @param {any} passable
+   * @param {Passable} passable
    * @returns {SmallcapsEncoding} except that `encodeToSmallcaps` does not generally
    * `harden` this result before returning. Rather, `encodeToSmallcaps` is not
    * directly exposed.

packages/marshal/src/marshal.js

@@ -79,7 +79,7 @@ export const makeMarshal = (
     const slotMap = new Map();
 
     /**
-     * @param {import('@endo/pass-style').PassableCap} passable
+     * @param {Remotable | Promise} passable
      * @returns {{index: number, repeat: boolean}}
      */
     const encodeSlotCommon = passable => {
@@ -134,7 +134,7 @@ export const makeMarshal = (
 
     if (serializeBodyFormat === 'capdata') {
       /**
-       * @param {import('@endo/pass-style').PassableCap} passable
+       * @param {Passable} passable
        * @param {InterfaceSpec} [iface]
        * @returns {Encoding}
        */
@@ -148,11 +148,9 @@ export const makeMarshal = (
         }
       };
 
-      /** @type {(promise: import('@endo/pass-style').RemotableObject, encodeRecur: (p: Passable) => Encoding) => Encoding} */
       const encodeRemotableToCapData = (val, _encodeRecur) =>
         encodeSlotToCapData(val, getInterfaceOf(val));
 
-      /** @type {(promise: Promise, encodeRecur: (p: Passable) => Encoding) => Encoding} */
       const encodePromiseToCapData = (promise, _encodeRecur) =>
         encodeSlotToCapData(promise);
 
@@ -186,7 +184,7 @@ export const makeMarshal = (
     } else if (serializeBodyFormat === 'smallcaps') {
       /**
        * @param {string} prefix
-       * @param {import('@endo/pass-style').PassableCap} passable
+       * @param {Passable} passable
        * @param {InterfaceSpec} [iface]
        * @returns {string}
        */
@@ -233,7 +231,7 @@ export const makeMarshal = (
   };
 
   const makeFullRevive = slots => {
-    /** @type {Map<number, Remotable | Promise>} */
+    /** @type {Map<number, Passable>} */
     const valMap = new Map();
 
     /**
@@ -244,9 +242,8 @@ export const makeMarshal = (
       const { iface = undefined, index, ...rest } = slotData;
       ownKeys(rest).length === 0 ||
         Fail`unexpected encoded slot properties ${q(ownKeys(rest))}`;
-      const extant = valMap.get(index);
-      if (extant) {
-        return extant;
+      if (valMap.has(index)) {
+        return valMap.get(index);
       }
       // TODO SECURITY HAZARD: must enfoce that remotable vs promise
       // is according to the encoded string.
@@ -270,12 +267,11 @@ export const makeMarshal = (
       // are for reuse by other encodings that do, such as smallcaps.
       const dName = decodeRecur(name);
       const dMessage = decodeRecur(message);
-      const dErrorId = /** @type {string} */ (errorId && decodeRecur(errorId));
+      const dErrorId = errorId && decodeRecur(errorId);
       typeof dName === 'string' ||
         Fail`invalid error name typeof ${q(typeof dName)}`;
-      if (typeof dMessage !== 'string') {
-        throw Fail`invalid error message typeof ${q(typeof dMessage)}`;
-      }
+      typeof dMessage === 'string' ||
+        Fail`invalid error message typeof ${q(typeof dMessage)}`;
       const EC = getErrorConstructor(dName) || Error;
       // errorId is a late addition so be tolerant of its absence.
       const errorName =
@@ -334,9 +330,7 @@ export const makeMarshal = (
     };
 
     const reviveFromSmallcaps = makeDecodeFromSmallcaps({
-      // @ts-expect-error FIXME
       decodeRemotableFromSmallcaps,
-      // @ts-expect-error FIXME
       decodePromiseFromSmallcaps,
       decodeErrorFromSmallcaps,
     });

packages/marshal/src/rankOrder.js

@@ -144,20 +144,16 @@ export const makeComparatorKit = (compareRemotables = (_x, _y) => 0) => {
       case 'string': {
         // Within each of these passStyles, the rank ordering agrees with
         // JavaScript's relational operators `<` and `>`.
-        // @ts-expect-error FIXME narrowed
         if (left < right) {
           return -1;
         } else {
-          // @ts-expect-error FIXME narrowed
           assert(left > right);
           return 1;
         }
       }
       case 'symbol': {
         return comparator(
-          // @ts-expect-error FIXME narrowed
           nameForPassableSymbol(left),
-          // @ts-expect-error FIXME narrowed
           nameForPassableSymbol(right),
         );
       }
@@ -171,11 +167,9 @@ export const makeComparatorKit = (compareRemotables = (_x, _y) => 0) => {
         }
         // The rank ordering of non-NaN numbers agrees with JavaScript's
         // relational operators '<' and '>'.
-        // @ts-expect-error FIXME narrowed
         if (left < right) {
           return -1;
         } else {
-          // @ts-expect-error FIXME narrowed
           assert(left > right);
           return 1;
         }
@@ -192,46 +186,37 @@ export const makeComparatorKit = (compareRemotables = (_x, _y) => 0) => {
         // of these names, which we then compare lexicographically. This ensures
         // that if the names of record X are a subset of the names of record Y,
         // then record X will have an earlier rank and sort to the left of Y.
-        // @ts-expect-error FIXME narrowed
         const leftNames = recordNames(left);
-        // @ts-expect-error FIXME narrowed
         const rightNames = recordNames(right);
 
         const result = comparator(leftNames, rightNames);
         if (result !== 0) {
           return result;
         }
         return comparator(
-          // @ts-expect-error FIXME narrowed
           recordValues(left, leftNames),
-          // @ts-expect-error FIXME narrowed
           recordValues(right, rightNames),
         );
       }
       case 'copyArray': {
         // Lexicographic
-        // @ts-expect-error FIXME narrowed
         const len = Math.min(left.length, right.length);
         for (let i = 0; i < len; i += 1) {
-          // @ts-expect-error FIXME narrowed
           const result = comparator(left[i], right[i]);
           if (result !== 0) {
             return result;
           }
         }
         // If all matching elements were tied, then according to their lengths.
         // If array X is a prefix of array Y, then X has an earlier rank than Y.
-        // @ts-expect-error FIXME narrowed
         return comparator(left.length, right.length);
       }
       case 'tagged': {
         // Lexicographic by `[Symbol.toStringTag]` then `.payload`.
-        // @ts-expect-error FIXME narrowed
         const labelComp = comparator(getTag(left), getTag(right));
         if (labelComp !== 0) {
           return labelComp;
         }
-        // @ts-expect-error FIXME narrowed
         return comparator(left.payload, right.payload);
       }
       default: {
@@ -301,10 +286,9 @@ harden(assertRankSorted);
  * function. This is a genuine bug for us NOW because sometimes we sort
  * in reverse order by passing a reversed rank comparison function.
  *
- * @template {Passable} T
- * @param {Iterable<T>} passables
+ * @param {Iterable<Passable>} passables
  * @param {RankCompare} compare
- * @returns {T[]}
+ * @returns {Passable[]}
  */
 export const sortByRank = (passables, compare) => {
   if (Array.isArray(passables)) {
@@ -398,20 +382,18 @@ export const coveredEntries = (sorted, [leftIndex, rightIndex]) => {
 harden(coveredEntries);
 
 /**
- * @template {Passable} T
  * @param {RankCompare} compare
- * @param {T} a
- * @param {T} b
- * @returns {T}
+ * @param {Passable} a
+ * @param {Passable} b
+ * @returns {Passable}
  */
 const maxRank = (compare, a, b) => (compare(a, b) >= 0 ? a : b);
 
 /**
- * @template {Passable} T
  * @param {RankCompare} compare
- * @param {T} a
- * @param {T} b
- * @returns {T}
+ * @param {Passable} a
+ * @param {Passable} b
+ * @returns {Passable}
  */
 const minRank = (compare, a, b) => (compare(a, b) <= 0 ? a : b);
 

packages/marshal/src/types.js

@@ -172,8 +172,8 @@ export {};
  * ordering would also compare magnitudes, and so agree with the rank ordering
  * of all values other than `NaN`. An array sorted by rank would enable range
  * queries by magnitude.
- * @param {import("@endo/pass-style").Passable} left
- * @param {import("@endo/pass-style").Passable} right
+ * @param {any} left a Passable
+ * @param {any} right a Passable
  * @returns {RankComparison}
  */
 

packages/marshal/test/test-marshal-capdata.js

@@ -311,7 +311,6 @@ test('records', t => {
   const fauxPresence = harden({});
   const { serialize: ser, unserialize: unser } = makeMarshal(
     _val => 'slot',
-    // @ts-expect-error mock
     _slot => fauxPresence,
     {
       errorTagging: 'off',
@@ -405,7 +404,6 @@ test('capdata proto problems', t => {
 test('capdata slot leniency', t => {
   const { unserialize: fromCapData } = makeMarshal(
     undefined,
-    // @ts-expect-error mock
     _slot => ({
       name: 'I should not be in a slot',
     }),

packages/marshal/test/test-marshal-far-obj.js

@@ -149,7 +149,6 @@ test('passStyleOf validation of remotables', t => {
   t.throws(() => passStyleOf(badRemotableProto3), NON_METHOD);
   t.throws(() => passStyleOf(badRemotableProto4), NON_METHOD);
 
-  // @ts-expect-error UNTIL https://github.com/microsoft/TypeScript/issues/38385
   t.is(passStyleOf(sub(goodRemotableProto)), 'remotable');
 
   t.throws(() => passStyleOf(sub(badRemotableProto1)), EXPECTED_PASS_STYLE);

packages/marshal/test/test-marshal-smallcaps.js

@@ -165,7 +165,6 @@ test('smallcaps records', t => {
   const fauxPresence = harden({});
   const { serialize: ser, unserialize: unser } = makeMarshal(
     _val => 'slot',
-    // @ts-expect-error mock
     _slot => fauxPresence,
     {
       errorTagging: 'off',