fix(compartment-mapper): fix #2407 include symbol-named properties

endojs · Aug 13, 2024 · 3efb14f · 3efb14f
1 parent 6ae7995
commit 3efb14f
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/packages/compartment-mapper/src/policy.js b/packages/compartment-mapper/src/policy.js
@@ -10,7 +10,9 @@ import {
   policyLookupHelper,
 } from './policy-format.js';
 
-const { create, entries, values, assign, keys, freeze } = Object;
+const { create, entries, values, assign, freeze, getOwnPropertyDescriptors } =
+  Object;
+const { ownKeys } = Reflect;
 const q = JSON.stringify;
 
 /**
@@ -28,7 +30,12 @@ export const ATTENUATORS_COMPARTMENT = '<ATTENUATORS>';
  */
 const selectiveCopy = (from, to, list) => {
   if (!list) {
-    list = keys(from);
+    const descs = getOwnPropertyDescriptors(from);
+    list = ownKeys(from).filter(
+      key =>
+        // @ts-expect-error TypeScript still confused about a symbol as index
+        descs[key].enumerable,
+    );
   }
   for (let index = 0; index < list.length; index += 1) {
     const key = list[index];