Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't try to create posixpath object from ssh key file content #37

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix: don't try to create posixpath object from ssh key file content #37

merged 1 commit into from
Dec 19, 2024

Conversation

frederik-encord
Copy link
Collaborator

With the previous implementation, ENCORD_SSH_KEY wouldn't work because Path("veeeery long key") would raise an exception. This fixes it.

@frederik-encord frederik-encord requested a review from a team as a code owner December 18, 2024 14:22
@frederik-encord frederik-encord merged commit 89d63ac into main Dec 19, 2024
2 checks passed
@frederik-encord frederik-encord deleted the fix/settings-ssh-key-content branch December 19, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jim-Encord Jim-Encord Jim-Encord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frederik-encord @Jim-Encord