fix: raw text data for gcp #36
Conversation
frederik-encord
force-pushed
the
fix/form-data-to-text
branch
from
fd019d9 to
b4f57e1
Compare
frederik-encord
force-pushed
the
fix/form-data-to-text
branch
from
54c3c0b to
3a34956
Compare
encord_agents/core/constants.py
Outdated
| @@ -0,0 +1,3 @@ | |||
| ENCORD_DOMAIN_REGEX = ( | |||
| r"^https:\/\/(?:(?:cord-ai-development--[\w\d]+-[\w\d]+\.web.app)|(?:(?:dev|staging|app)\.encord\.com))$" | |||
There was a problem hiding this comment.
Also need us suffix 🇺🇸 . I think optional us suffix on dev|staging|app but may need to check:
i.e: https://app.us.encord.com/ is the path to the base app
There was a problem hiding this comment.
Uh - well spotted. I was not aware of this tbh.
There was a problem hiding this comment.
@Jim-Encord fixed this now. Also added a unit test for the CORS regex just to make it clear what it should and shouldn't match.
|
|
||
| if request.is_json: | ||
| frame_data = FrameData.model_validate(request.get_json()) | ||
| else: |
There was a problem hiding this comment.
Is this necessary or just defensive?
Is it worth having a try/ except around these conditions given that it could throw?
There was a problem hiding this comment.
Might add a TODO to remove it by end of January where we'll remove the reverse feature flag. It's a protection for anyone who update the repo where it used to work. Those will have the reverse FF set until eo-jan. So upgrading like this should keep it working for them.
There was a problem hiding this comment.
Added the TODO
No description provided.