This repository has been archived by the owner on Nov 10, 2022. It is now read-only.
Bring back "load module from fd" #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgwoods
force-pushed
the
module-on-fd
branch
2 times, most recently
from
4b318f3
to
e20f294
Compare
npmccallum
suggested changes
Aug 24, 2021
src/main.rs
Outdated
| let mut reader = File::open(&path) | ||
| .with_context(|| format!("failed opening {:?}", path))?; | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't like cfg_if! in general. And it doesn't make sense here either. Let's find a way to split this more reasonably and drop the dependency.
There was a problem hiding this comment.
Pushed an updated version that drops cfg_if in favor of a helper function.
This patch brings back the ability to load the module to be run from an open file descriptor, which must be 3 or higher (so as not to collide with stdin/stdout/stderr). It also tweaks CLI parsing slightly - the '--' separating wasmldr args from module args is now required. Signed-off-by: Will Woods <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the previous PR (#100) and brings back the ability to load the WebAssembly module from an inherited file descriptor, using the new
--module-on-fd NUMflag. (The docstring in main.rs has been updated accordingly.)