-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump commander from 7.2.0 to 12.0.0 #236
build(deps): bump commander from 7.2.0 to 12.0.0 #236
Conversation
Bumps [commander](https://github.com/tj/commander.js) from 7.2.0 to 12.0.0. - [Release notes](https://github.com/tj/commander.js/releases) - [Changelog](https://github.com/tj/commander.js/blob/master/CHANGELOG.md) - [Commits](tj/commander.js@v7.2.0...v12.0.0) --- updated-dependencies: - dependency-name: commander dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
This seems to work for me. This provides our commands to the cli so it isn't a small part. I tweaked some things for deprecations since the original use of this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we can remove "@types/commander": "^2.12.2",
completely. I was getting the following deprecation warning when installing and the package page recommends ditching it completely. https://www.npmjs.com/package/@types/commander
npm WARN deprecated @types/[email protected]: This is a stub types definition for comman
I tried updating .nvmrc
to 20
and went through the install without issues. Might be a good idea to bump that as well given emulsify-drupal
and emulsify-core
are already running with those versions.
Otherwise, the minor refactoring you needed to do here looks good to me.
@callinmullaney Done! I agree that we should be using node 20 and it does seem we can get away from that dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 This PR is included in version 1.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Bumps commander from 7.2.0 to 12.0.0.
Release notes
Sourced from commander's releases.
... (truncated)
Changelog
Sourced from commander's changelog.
... (truncated)
Commits
83c3f4e
Bump version to 12.0.0e3192a1
Merge pull request #2140 from tj/release/12.x608eaf0
Update CHANGELOG for v12 (#2133)3f44d29
Update dependencies preparing for release (#2132)4d832b2
Merge remote-tracking branch 'origin/develop' into release/12.xb53109b
Add links in CHANGELOG90f3c8a
12.0.0-1eed665d
Add 12.0.0-1 changes to CHANGELOG09244af
Refactor help option implementation to hold actual Option (#2006)ff08a02
Refactor help command implementation to hold actual Command (#2087)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)This affects our actual cli commands so we should put this through paces a bit with init, system, and component install commands.