Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create component command #234

Merged
merged 12 commits into from
Dec 13, 2024
Merged

Create component command #234

merged 12 commits into from
Dec 13, 2024

Conversation

robherba
Copy link
Collaborator

@robherba robherba commented Oct 3, 2023

Summary

Adds a command to generate the basic structure of a new component.

How to review this pull request

  • Pull this branch down, run npm build && npm link
  • Create a new Drupal project, you can use composer create-project drupal/recommended-project drupal-folder.
  • Set up a new theme using emulsify.
  • Install the compound project with emulsify system install compound --all.
  • Create a custom component using emulsify component create componentName -d directoryName (directoryName: atoms | molecules | organisms | templates)

@robherba robherba added the 👍 Ready for Review Work is ready for review. label Oct 3, 2023
@robherba robherba self-assigned this Oct 3, 2023
@mariannuar mariannuar added 👁 Review in progress Under review. and removed 👍 Ready for Review Work is ready for review. labels Nov 2, 2023
Copy link

@mariannuar mariannuar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great to me! 🎉

@mariannuar mariannuar added 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Passes Code Review Code is approved by the reviewer. 🎉 Ready to Merge Functionality is approved by the reviewer. and removed 👁 Review in progress Under review. labels Nov 2, 2023
@callinmullaney callinmullaney self-requested a review November 30, 2023 17:25
@robherba robherba added the 🚧 Work in Progress The PR is a work in progress. label Dec 4, 2023
@robherba robherba removed the 🚧 Work in Progress The PR is a work in progress. label Dec 4, 2023
Copy link

sync-by-unito bot commented Feb 1, 2024

➤ Fabiola Fallas Cascante commented:

@roberto Hernández Badilla @mariana Núñez This is ready to merge?

Copy link

sync-by-unito bot commented Feb 1, 2024

➤ Mariana Núñez commented:

@fabiola Fallas Cascante Not sure. There were some new commits after I approved it. I believe it was based on @Callin Mullaney feedback. Maybe he and Roberto have the answer 🙂

Copy link

sync-by-unito bot commented Feb 1, 2024

➤ Callin Mullaney commented:

@fabiola Fallas Cascante This is still a work-in-progress. I moved to review/Qa as Roberto was addressing additional feedback. Once that's in place and I have a chance to confirm I'll ping MikeG for the final merge as he's the repository lead. cc: @mariana Núñez

Copy link

sync-by-unito bot commented Feb 1, 2024

➤ Mike Goulding commented:

I'd ideally like to have this have a test written before merging this as we have that for other similar commands. I could help with that part if needed.

@callinmullaney callinmullaney added 👉 Needs Work Reviewer has requested changes. and removed 🎉 Ready to Merge Functionality is approved by the reviewer. 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Passes Code Review Code is approved by the reviewer. labels Apr 11, 2024
@mikeethedude
Copy link
Contributor

@robherba Do you want to give this another go with tests now? We can pull this into 2.x if you want too

@robherba robherba added 🚧 Work in Progress The PR is a work in progress. and removed 👉 Needs Work Reviewer has requested changes. labels Sep 30, 2024
@robherba robherba changed the base branch from develop to 2.x September 30, 2024 23:00
Copy link
Contributor

@mikeethedude mikeethedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of issues with imports on the component create command but otherwise this looks great. Just remember that relative imports need the .js file extension

src/handlers/componentCreate.ts Outdated Show resolved Hide resolved
src/handlers/componentCreate.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@mikeethedude mikeethedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thank you for adding this!

@mikeethedude mikeethedude added 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Passes Code Review Code is approved by the reviewer. 🎉 Ready to Merge Functionality is approved by the reviewer. and removed 🚧 Work in Progress The PR is a work in progress. labels Dec 13, 2024
@robherba robherba merged commit 73d4774 into 2.x Dec 13, 2024
@robherba robherba deleted the create-component-command branch December 13, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 Passes Code Review Code is approved by the reviewer. 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Ready to Merge Functionality is approved by the reviewer.
Projects
No open projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

4 participants