Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[emmalloc] Fix verbose output #23069

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kleisauke
Copy link
Collaborator

toString() is undeclared.

Fixes a regression introduced in commit 04a0cad.

`toString()` is undeclared.

Fixes a regression introduced in commit 04a0cad.
@kleisauke
Copy link
Collaborator Author

Details:

building:ERROR: Closure compiler run failed:

building:ERROR: /tmp/emscripten_temp_50snxhja/vips-es6.jso3.js:757:85: ERROR - [JSC_UNDEFINED_VARIABLE] variable toString is undeclared
  757|     out("aligned_realloc(ptr=" + ptrToString($0) + ", alignment=" + $1 + ", size=" + toString(Number($2)));
                                                                                            ^^^^^^^^

1 error(s), 0 warning(s)

@kripken kripken requested a review from sbc100 December 4, 2024 17:35
@sbc100
Copy link
Collaborator

sbc100 commented Dec 4, 2024

Are we missing a test for -sMALLOC=emmalloc-verbose?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants