Handle trailing % in strftime #23045
Conversation
"In glibc a trailing % in strftime() acts like printf, ie it's a literal %". This is breaking some Python tests. I've applied the patch suggested here: https://www.openwall.com/lists/musl/2022/12/19/2
|
I guess this would have to be addressed upstream with musl though. |
|
Perhaps the python tests themselves should be updated? Otherwise they cannot run on any musl-based platform (e.g. alpine linux). |
|
Generally I try to fix both sides =) |
|
I think it works on other musl systems as long as they support wide characters. The problem affects systems that use musl or bsd libc and where |
|
Ah.. In that case we can/should also be including wcsftime.. i don't know why we don't already include that. |
|
I looked into turning that on too but I couldn't figure out how it was determined. But I think this change is an improvement in either case. |
|
This change lgtm with comments addressed. |
|
wcsftime being added in #23061 |
|
Okay I addressed the comments I think. |
"In glibc a trailing % in strftime() acts like printf, ie it's a literal %". This is breaking some Python tests. I've applied the patch suggested here: https://www.openwall.com/lists/musl/2022/12/19/2