When opening broken symlink with O_CREAT, create file at target #23002
+64
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
hoodmane
changed the title
Instead of raising an EEXIST error
hoodmane
force-pushed
the
open-broken-link-create
branch
from
55152ce
to
5bd422e
Compare
hoodmane
commented
Nov 25, 2024
src/library_fs.js
Outdated
Comment on lines
223
to
226
| if (!current.node_ops.readlink) { | ||
| throw new FS.ErrnoError({{{ cDefs.ENOSYS }}}); | ||
| } | ||
| var link = current.node_ops.readlink(current); |
There was a problem hiding this comment.
Before this change, FS.readlink calls lookupPath again which repeats exactly the same work we've done up to this point in this function except with opts.follow false. Rather than doing that, we already have the node here so I figure it's better just to call node_ops.readlink.
sbc100
reviewed
Nov 25, 2024
sbc100
reviewed
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we open a broken symlink with
O_CREATwe should create a new file as the target of the symlink.This resolves #23001.
To fix the problem, I added an extra
handleBrokenLinkoption tolookupPath. When this option is passed, if the input path is a broken symlink, instead of raisingEEXIST, it returns{ path: theTarget, node: undefined}. Then inopenwe updatepathbased on the returned path, so if the node doesn't exist we attempt create it at the resolved target path of the symlink rather than trying to create it on the source of the symlink which raisesEEXISTagain.