Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MAIN_MODULE=1 + STRICT #22446

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Fix MAIN_MODULE=1 + STRICT #22446

merged 1 commit into from
Aug 24, 2024

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Aug 23, 2024

Fixes: #22435

@sbc100 sbc100 requested review from kripken and dschuff August 23, 2024 23:43
@sbc100 sbc100 mentioned this pull request Aug 23, 2024
Closed
@sbc100 sbc100 enabled auto-merge (squash) August 24, 2024 00:42
@sbc100 sbc100 merged commit 561e0c9 into emscripten-core:main Aug 24, 2024
27 checks passed
@sbc100 sbc100 deleted the main_module_strict branch August 24, 2024 00:55
@hoodmane
Copy link
Collaborator

Thanks for the help @sbc100!

@dschuff dschuff mentioned this pull request Oct 29, 2024
Merged
@dschuff dschuff mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschuff dschuff dschuff approved these changes

@kripken kripken Awaiting requested review from kripken

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbc100 @hoodmane @dschuff