Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calling transpile method after modularising #22390

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

drwwoob
Copy link
Contributor

@drwwoob drwwoob commented Aug 16, 2024

from issue #22290

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like moving this to later will cause it to run after wasm2js. That might not be harmful, but it is potentially a lot more work, to process all the wasm2js output and not do anything on it.

Can we perhaps reorder the other way, that is, move the modularization forward?

@drwwoob
Copy link
Contributor Author

drwwoob commented Aug 27, 2024

closed with the solution provided in #22385.

@drwwoob drwwoob closed this Aug 27, 2024
@drwwoob drwwoob deleted the orderchange-compatible branch August 27, 2024 02:07
@drwwoob drwwoob restored the orderchange-compatible branch August 27, 2024 13:52
@drwwoob drwwoob reopened this Aug 27, 2024
@sbc100
Copy link
Collaborator

sbc100 commented Aug 27, 2024

I'm not really sure its worth fixing this, given that #22385 has landed. Sorry to be flip flopping on this. Unless you can see of a clear advantage?

I guess it depend how many modern JS features we might want to use the modularization code? If its just one conditional assignment maybe its not worth it?

@drwwoob
Copy link
Contributor Author

drwwoob commented Aug 28, 2024

I'm not really sure its worth fixing this, given that #22385 has landed. Sorry to be flip flopping on this. Unless you can see of a clear advantage?

I guess it depend how many modern JS features we might want to use the modularization code? If its just one conditional assignment maybe its not worth it?

So far the only modern JS issue I've encountered is the one that's being fixed in #22385, I would say that the fix is a good-enough solution for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants