-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calling transpile method after modularising #22390
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like moving this to later will cause it to run after wasm2js
. That might not be harmful, but it is potentially a lot more work, to process all the wasm2js output and not do anything on it.
Can we perhaps reorder the other way, that is, move the modularization forward?
closed with the solution provided in #22385. |
I'm not really sure its worth fixing this, given that #22385 has landed. Sorry to be flip flopping on this. Unless you can see of a clear advantage? I guess it depend how many modern JS features we might want to use the modularization code? If its just one conditional assignment maybe its not worth it? |
So far the only modern JS issue I've encountered is the one that's being fixed in #22385, I would say that the fix is a good-enough solution for me. |
from issue #22290