-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advance resource management #320
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qzhuyan
force-pushed
the
feat/william/adv-res-mgmt
branch
from
November 15, 2024 11:06
406d339
to
65a5c98
Compare
qzhuyan
force-pushed
the
feat/william/adv-res-mgmt
branch
from
November 15, 2024 11:08
65a5c98
to
31031a2
Compare
Pull Request Test Coverage Report for Build 11929767256Details
💛 - Coveralls |
qzhuyan
commented
Nov 17, 2024
no longer do refcnt with enif_keep_resource enif_release_resource
zmstone
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tend to decopule the lifetime of msquic handle and nif resource context.
The resource in msquic could be released earlier before the deallocation of erlang NIF resource with some cost of extra refcnts overheads.
Benefits:
TODOs:
targeting ver: 0.2