Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: monitor remote stream #314

Merged
merged 6 commits into from
Oct 28, 2024
Merged

feat: monitor remote stream #314

merged 6 commits into from
Oct 28, 2024

Conversation

qzhuyan
Copy link
Collaborator

@qzhuyan qzhuyan commented Oct 23, 2024 •
edited
Loading

  • add support for monitoring remote stream
  • fix some proper tests.
  • more safe trace points in tests.

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 23, 2024
View reviewed changes
c_src/quicer_connection.c Fixed Show fixed Hide fixed
@qzhuyan qzhuyan force-pushed the dev/william/monitor-remote-stream branch 2 times, most recently from 1781a67 to 686cbe4 Compare October 23, 2024 19:41
@qzhuyan qzhuyan force-pushed the dev/william/monitor-remote-stream branch from 686cbe4 to 4e15382 Compare October 26, 2024 14:33
@coveralls
Copy link

coveralls commented Oct 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11551948298

Details

  • 23 of 24 (95.83%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 86.539%
Changes Missing Coverage Covered Lines Changed/Added Lines %
c_src/quicer_connection.c 15 16 93.75%
Files with Coverage Reduction New Missed Lines %
c_src/quicer_listener.c 1 88.85%
Totals Coverage Status
Change from base Build 11501859384: 0.1%
Covered Lines: 3973
Relevant Lines: 4591
💛 - Coveralls

@qzhuyan qzhuyan force-pushed the dev/william/monitor-remote-stream branch from 4e15382 to f769712 Compare October 26, 2024 20:04
@qzhuyan qzhuyan changed the title Dev/william/monitor remote stream feat: monitor remote stream Oct 28, 2024
@qzhuyan qzhuyan merged commit 895252a into emqx:main Oct 28, 2024
44 checks passed
@qzhuyan qzhuyan deleted the dev/william/monitor-remote-stream branch October 28, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thalesmg thalesmg thalesmg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qzhuyan @coveralls @thalesmg