Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump OTP vsns #295

Merged
merged 1 commit into from
Sep 19, 2024
Merged

ci: bump OTP vsns #295

merged 1 commit into from
Sep 19, 2024

Conversation

qzhuyan
Copy link
Collaborator

@qzhuyan qzhuyan commented Sep 19, 2024

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10940860474

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 86.752%

Files with Coverage Reduction New Missed Lines %
c_src/quicer_config.c 6 87.08%
Totals Coverage Status
Change from base Build 10918434043: -0.04%
Covered Lines: 3883
Relevant Lines: 4476

💛 - Coveralls

Comment on lines +90 to +91
- 25.3.2.9
- 26.2.5.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: shouldn't these match the versions we use in release.yaml?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci test use unmodified OTP, release use EMQX forked OTP.
good coverage and make both happy. 😄

@qzhuyan qzhuyan merged commit 54ceaaa into emqx:main Sep 19, 2024
32 checks passed
@qzhuyan qzhuyan deleted the ci/william/bump-otp-vsns branch September 19, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants