Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mem leaks with invalid TLS configs #264

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

qzhuyan
Copy link
Collaborator

@qzhuyan qzhuyan commented Feb 21, 2024

Fix mem leaks detected by proper tests.
They are all negative cases when invalid tls configs are failed to set but some object like intermediate string (from Erlang term to string) is not released.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7995384007

Details

  • -13 of 19 (31.58%) changed or added relevant lines in 4 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 83.697%

Changes Missing Coverage Covered Lines Changed/Added Lines %
c_src/quicer_config.c 0 2 0.0%
c_src/quicer_listener.c 0 2 0.0%
c_src/quicer_connection.c 0 3 0.0%
c_src/quicer_tls.c 6 12 50.0%
Files with Coverage Reduction New Missed Lines %
c_src/quicer_listener.c 2 85.9%
c_src/quicer_stream.c 2 85.14%
Totals Coverage Status
Change from base Build 7964607610: -0.2%
Covered Lines: 3604
Relevant Lines: 4306

💛 - Coveralls

@qzhuyan qzhuyan merged commit 5f1068f into emqx:main Feb 22, 2024
24 checks passed
@qzhuyan qzhuyan deleted the fix/william/proper-memleak branch February 22, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants