Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: QUIC cred config #252

Merged
merged 4 commits into from
Dec 22, 2023
Merged

refactor: QUIC cred config #252

merged 4 commits into from
Dec 22, 2023

Conversation

qzhuyan
Copy link
Collaborator

@qzhuyan qzhuyan commented Dec 21, 2023

  • remove cacertfile from l_ctx
  • new "cred config" builder function

@coveralls
Copy link

coveralls commented Dec 21, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7293010275

  • 44 of 49 (89.8%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 83.556%
Changes Missing Coverage Covered Lines Changed/Added Lines %
c_src/quicer_listener.c 12 13 92.31%
src/quicer_listener.erl 0 1 0.0%
c_src/quicer_tls.c 32 35 91.43%
Files with Coverage Reduction New Missed Lines %
c_src/quicer_stream.c 2 85.14%
Totals Coverage Status
Change from base Build 7285617898: 0.07%
Covered Lines: 3501
Relevant Lines: 4190
💛 - Coveralls

qzhuyan
qzhuyan commented Dec 21, 2023
View reviewed changes
c_src/quicer_ctx.h Outdated Show resolved Hide resolved
@qzhuyan qzhuyan force-pushed the dev/william/cacertfile-in-tls-ctx branch from 36c5254 to 18c30e0 Compare December 21, 2023 20:43
@qzhuyan qzhuyan marked this pull request as ready for review December 21, 2023 21:41
thalesmg
thalesmg approved these changes Dec 22, 2023
View reviewed changes
c_src/quicer_listener.c
cacertfile = NULL;
free_certificate(&CredConfig);
return ERROR_TUPLE_2(ATOM_CACERTFILE);
return ERROR_TUPLE_2(ret);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: should we free_certificate(&CredConfig) here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eoptions_to_cred_config take cares of that.

@qzhuyan qzhuyan merged commit 6b1825d into emqx:main Dec 22, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thalesmg thalesmg thalesmg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qzhuyan @coveralls @thalesmg