feat: add dgram recv callback #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
qzhuyan
commented
Dec 18, 2023
qzhuyan
commented
- add dgram recv callback
- fixing naming of datagram -> dgram
- fix some confusion perf profile naming
- add dgram_recv callback in quicer_connection - align naming datagram => dgram
ieQu1
reviewed
Dec 18, 2023
| ListenerOpts = [{conn_acceptors, 4} | default_listen_opts(Config)], | ||
| ConnectionOpts = [ {conn_callback, ServerConnCallback} | ||
| , {stream_acceptors, 2} | ||
| | default_conn_opts()], |
There was a problem hiding this comment.
I will format the code with erlfmt in the next PR.
thalesmg
approved these changes
Dec 18, 2023
Comment on lines
+474
to
+476
| , {disable_fpbuffer, true} | ||
| | default_stream_opts() ], | ||
| %% GIVEN: A listener with datagram_receive_enabled = false |
There was a problem hiding this comment.
Q: should disable_fpbuffer = true above be datagram_receive_enabled = false?
Or maybe explicitly set it in ListenerOpts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.