Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: list connections under registration #231

Merged
merged 1 commit into from
Nov 22, 2023
Merged

feat: list connections under registration #231

merged 1 commit into from
Nov 22, 2023

Conversation

qzhuyan
Copy link
Collaborator

@qzhuyan qzhuyan commented Nov 17, 2023 •
edited
Loading

fix #207

@coveralls
Copy link

coveralls commented Nov 17, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6942411576

  • 44 of 50 (88.0%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 83.057%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/quicer.erl 2 3 66.67%
src/quicer_nif.erl 0 2 0.0%
c_src/quicer_connection.c 27 30 90.0%
Files with Coverage Reduction New Missed Lines %
src/quicer_nif.erl 1 26.56%
Totals Coverage Status
Change from base Build 6853776401: 0.1%
Covered Lines: 3402
Relevant Lines: 4096
💛 - Coveralls

@qzhuyan qzhuyan force-pushed the dev/william/list-conns branch from 4174010 to 4a519b1 Compare November 18, 2023 16:03
@qzhuyan qzhuyan marked this pull request as ready for review November 20, 2023 18:28
@qzhuyan qzhuyan force-pushed the dev/william/list-conns branch from 4a519b1 to 3e48c9e Compare November 21, 2023 10:24
@qzhuyan qzhuyan merged commit d58d8fe into emqx:main Nov 22, 2023
25 checks passed
@qzhuyan qzhuyan deleted the dev/william/list-conns branch November 22, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangjiaxingict zhangjiaxingict zhangjiaxingict approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Listing connections
3 participants
@qzhuyan @coveralls @zhangjiaxingict