Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support emqx dashboard https port #966

Merged
merged 1 commit into from
Oct 25, 2023
Merged

feat: support emqx dashboard https port #966

merged 1 commit into from
Oct 25, 2023

Conversation

Rory-Z
Copy link
Member

@Rory-Z Rory-Z commented Oct 24, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Files Coverage Δ
apis/apps/v2beta1/util.go 75.49% <100.00%> (+5.45%) ⬆️
controllers/apps/v2beta1/add_emqx_core.go 95.94% <100.00%> (+2.21%) ⬆️
controllers/apps/v2beta1/add_emqx_repl.go 95.60% <100.00%> (+2.39%) ⬆️
controllers/apps/v2beta1/add_svc.go 70.80% <100.00%> (+0.05%) ⬆️
internal/requester/requester.go 75.00% <75.00%> (+1.66%) ⬆️
controllers/apps/v2beta1/update_pod_conditions.go 83.33% <66.66%> (-0.39%) ⬇️
controllers/apps/v2beta1/emqx_controller.go 84.16% <53.84%> (-2.68%) ⬇️

... and 4 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@Rory-Z Rory-Z merged commit ad4f74c into emqx:main Oct 25, 2023
38 checks passed
@Rory-Z Rory-Z deleted the feat/support-emqx-dashboard-https branch October 25, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant