Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: "toleRations" should be "tolerations" by Kubernetes conventions #945

Merged
merged 1 commit into from
Sep 8, 2023
Merged

fix: "toleRations" should be "tolerations" by Kubernetes conventions #945

merged 1 commit into from
Sep 8, 2023

Conversation

Rory-Z
Copy link
Member

@Rory-Z Rory-Z commented Sep 7, 2023

Fix #944

@Rory-Z Rory-Z requested a review from a team as a code owner September 7, 2023 10:03
@codecov
Copy link

codecov bot commented Sep 8, 2023 •
edited
Loading

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
apis/apps/v2beta1/emqx_types.go ø
controllers/apps/v2beta1/add_emqx_core.go 100.00%
controllers/apps/v2beta1/add_emqx_repl.go 100.00%

📢 Thoughts on this report? Let us know!.

@Rory-Z Rory-Z merged commit de8d31d into emqx:main Sep 8, 2023
37 of 38 checks passed
@Rory-Z Rory-Z deleted the fix/fix-typo branch September 8, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2beta1 EMQXReplicantTemplateSpec."toleRations" should be "tolerations" by Kubernetes conventions
1 participant
@Rory-Z