Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete default metadata in webhook #924

Merged
merged 1 commit into from
Aug 16, 2023
Merged

chore: delete default metadata in webhook #924

merged 1 commit into from
Aug 16, 2023

Conversation

Rory-Z
Copy link
Member

@Rory-Z Rory-Z commented Aug 16, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 97.24% and project coverage change: -0.09% ⚠️

Comparison is base (4048aea) 77.34% compared to head (694e614) 77.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #924      +/-   ##
==========================================
- Coverage   77.34%   77.26%   -0.09%     
==========================================
  Files          67       67              
  Lines        6035     6038       +3     
==========================================
- Hits         4668     4665       -3     
- Misses       1141     1147       +6     
  Partials      226      226              
Files Changed Coverage Δ
apis/apps/v2beta1/emqx_webhook.go 92.85% <ø> (-3.64%) ⬇️
apis/apps/v2beta1/util.go 70.03% <89.65%> (-1.40%) ⬇️
apis/apps/v2beta1/names.go 100.00% <100.00%> (ø)
controllers/apps/v2beta1/add_bootstrap_resource.go 89.47% <100.00%> (ø)
controllers/apps/v2beta1/add_emqx_core.go 90.66% <100.00%> (+0.15%) ⬆️
controllers/apps/v2beta1/add_emqx_repl.go 89.92% <100.00%> (+0.18%) ⬆️
controllers/apps/v2beta1/add_svc.go 76.86% <100.00%> (+1.86%) ⬆️
controllers/apps/v2beta1/emqx_controller.go 89.92% <100.00%> (+1.55%) ⬆️
controllers/apps/v2beta1/sync_emqx_config.go 63.54% <100.00%> (+6.25%) ⬆️
controllers/apps/v2beta1/update_emqx_status.go 77.48% <100.00%> (ø)
... and 2 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rory-Z Rory-Z merged commit e7baafd into emqx:main Aug 16, 2023
36 of 37 checks passed
@Rory-Z Rory-Z deleted the chore/delete-default-webhook branch August 16, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant