Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete default svc template in webhook #923

Merged
merged 2 commits into from
Aug 16, 2023
Merged

chore: delete default svc template in webhook #923

merged 2 commits into from
Aug 16, 2023

Conversation

Rory-Z
Copy link
Member

@Rory-Z Rory-Z commented Aug 15, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 61.78% and project coverage change: -0.46% ⚠️

Comparison is base (caaf5bc) 78.01% compared to head (5b8e0a1) 77.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #923      +/-   ##
==========================================
- Coverage   78.01%   77.56%   -0.46%     
==========================================
  Files          67       67              
  Lines        5991     6035      +44     
==========================================
+ Hits         4674     4681       +7     
- Misses       1097     1131      +34     
- Partials      220      223       +3     
Files Changed Coverage Δ
apis/apps/v2beta1/emqx_webhook.go 96.49% <ø> (-0.64%) ⬇️
controllers/apps/v2beta1/add_svc.go 77.20% <58.20%> (-10.17%) ⬇️
controllers/apps/v2beta1/add_emqx_core.go 90.50% <63.63%> (-2.73%) ⬇️
controllers/apps/v2beta1/add_emqx_repl.go 89.74% <63.63%> (-2.93%) ⬇️
controllers/apps/v2beta1/emqx_controller.go 88.37% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rory-Z Rory-Z merged commit 4048aea into emqx:main Aug 16, 2023
@Rory-Z Rory-Z deleted the chore/delete-default-webhook branch August 16, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant