Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs fix: Replace all kubernetes API links #1058

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

Fluder-Paradyne
Copy link
Contributor

@Fluder-Paradyne Fluder-Paradyne commented Jun 13, 2024

Seems like all docs of v1.22 has been removed from kubernetes docs site,
Right now minimum available version for which docs is available is 1.23.
So I have replaced all the links

@Fluder-Paradyne Fluder-Paradyne requested a review from a team as a code owner June 13, 2024 16:21
@Rory-Z
Copy link
Member

Rory-Z commented Jun 18, 2024

Hi @Fluder-Paradyne Thanks for your code. but we use the elastic/crd-ref-docs to generate API docs, So I think just update ./crd-reference-config.yaml and running make manifests will be work.
And could you please change your git commit log to pass the lint check? You can see this document

Signed-off-by: Fluder-Paradyne <[email protected]>
@Fluder-Paradyne
Copy link
Contributor Author

Fluder-Paradyne commented Jun 18, 2024

Hey sorry about that, have fixed it now,
also when running make manifest got issue with running CONTROLLER_GEN, so only ran gen-crd-ref-docs because this is docs only. is it fine ?

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.60%. Comparing base (942c417) to head (9e6bef0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1058      +/-   ##
==========================================
+ Coverage   76.40%   76.60%   +0.20%     
==========================================
  Files          69       69              
  Lines        6250     6250              
==========================================
+ Hits         4775     4788      +13     
+ Misses       1237     1227      -10     
+ Partials      238      235       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rory-Z Rory-Z merged commit 4338777 into emqx:main Jun 18, 2024
34 checks passed
rouke-broersma referenced this pull request in broersma-forslund/homelab Sep 24, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [emqx-operator](https://redirect.github.com/emqx/emqx-operator)
([source](https://redirect.github.com/emqx/emqx-operator/tree/HEAD/deploy/charts/emqx-operator))
| patch | `2.2.23` -> `2.2.24` |

---

### Release Notes

<details>
<summary>emqx/emqx-operator (emqx-operator)</summary>

###
[`v2.2.24`](https://redirect.github.com/emqx/emqx-operator/releases/tag/2.2.24):
EMQX Operator 2.2.24 Released

[Compare
Source](https://redirect.github.com/emqx/emqx-operator/compare/2.2.23...2.2.24)

### Release Note 🍻

EMQX Operator 2.2.24 has been released.

#### Supported version

-   apps.emqx.io/v2beta1

    -   EMQX at 5.1.1 and later
    -   EMQX Enterprise at 5.1.1 and later

-   apps.emqx.io/v1beta4

    -   EMQX at 4.4.14 and later
    -   EMQX Enterprise at 4.4.14 and later

#### Enhancements 🚀

-   `apps.emqx.io/v2beta1 EMQX`.

- Fix sometimes cannot update EMQX's configuration when EMQX is running.

#### How to install/upgrade EMQX Operator 💡

> Need make sure the [cert-manager](https://cert-manager.io/) is ready

    helm repo add emqx https://repos.emqx.io/charts
    helm repo update
    helm upgrade --install emqx-operator emqx/emqx-operator \
      --namespace emqx-operator-system \
      --create-namespace \
      --version 2.2.24
kubectl wait --for=condition=Ready pods -l
"control-plane=controller-manager" -n emqx-operator-system

#### Warning 🚨

`apps.emqx.io/v1beta3` and `apps.emqx.io/v2alpha1` will be dropped soon

#### What's Changed

- Docs fix: Replace all kubernetes API links by
[@&#8203;Fluder-Paradyne](https://redirect.github.com/Fluder-Paradyne)
in
[https://github.com/emqx/emqx-operator/pull/1058](https://redirect.github.com/emqx/emqx-operator/pull/1058)
- ci: push multi image to ghcr when release by
[@&#8203;Rory-Z](https://redirect.github.com/Rory-Z) in
[https://github.com/emqx/emqx-operator/pull/1065](https://redirect.github.com/emqx/emqx-operator/pull/1065)
- chore: dump controller-gen version by
[@&#8203;Rory-Z](https://redirect.github.com/Rory-Z) in
[https://github.com/emqx/emqx-operator/pull/1066](https://redirect.github.com/emqx/emqx-operator/pull/1066)
- fix: fix nil pointer error by
[@&#8203;Rory-Z](https://redirect.github.com/Rory-Z) in
[https://github.com/emqx/emqx-operator/pull/1067](https://redirect.github.com/emqx/emqx-operator/pull/1067)
- Revert "fix: fix nil pointer error" by
[@&#8203;Rory-Z](https://redirect.github.com/Rory-Z) in
[https://github.com/emqx/emqx-operator/pull/1068](https://redirect.github.com/emqx/emqx-operator/pull/1068)
- chore: dump kube version to 0.16.3 by
[@&#8203;Rory-Z](https://redirect.github.com/Rory-Z) in
[https://github.com/emqx/emqx-operator/pull/1074](https://redirect.github.com/emqx/emqx-operator/pull/1074)
- feat: use original config to PUT EMQX configs api by
[@&#8203;Rory-Z](https://redirect.github.com/Rory-Z) in
[https://github.com/emqx/emqx-operator/pull/1073](https://redirect.github.com/emqx/emqx-operator/pull/1073)

#### New Contributors

- [@&#8203;Fluder-Paradyne](https://redirect.github.com/Fluder-Paradyne)
made their first contribution in
[https://github.com/emqx/emqx-operator/pull/1058](https://redirect.github.com/emqx/emqx-operator/pull/1058)

**Full Changelog**:
emqx/emqx-operator@2.2.23...2.2.24

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/broersma-forslund/homelab).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants