Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: do not set BUILD_WITHOUT_QUIC env var in release workflow #254

Merged
merged 1 commit into from
Aug 22, 2024
Merged

ci: do not set BUILD_WITHOUT_QUIC env var in release workflow #254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ jobs:
- amzn2023
env:
IMAGE: ghcr.io/emqx/emqx-builder/5.3-7:1.15.7-${{ matrix.otp }}-${{ matrix.os }}
BUILD_WITHOUT_QUIC: ${{ matrix.quic_support && '' || '1' }}

steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
Expand All @@ -86,10 +85,11 @@ jobs:
ref: ${{ github.event.inputs.branch_or_tag }}
- name: build
run: >-
docker run --rm -v ${PWD}:/wd -w /wd -e BUILD_WITHOUT_QUIC=${BUILD_WITHOUT_QUIC} ${IMAGE} bash -euc "
git config --global --add safe.directory '*';
make
"
if [ "false" == ${{ matrix.quic_support }} ]; then
docker run --rm -v ${PWD}:/wd -w /wd -e BUILD_WITHOUT_QUIC=1 ${IMAGE} bash -euc "git config --global --add safe.directory '*' && make"
else
docker run --rm -v ${PWD}:/wd -w /wd ${IMAGE} bash -euc "git config --global --add safe.directory '*' && make"
fi
- if: failure()
run: cat rebar3.crashdump
- name: Verify that we have working release
Expand Down
Loading