fix(autoheal): attempt healing complex asymmetric partitions #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also introduce additional retry mechanisms: * On autoheal process crash. * On unreachable nodes during gathering cluster views.
Assuming complex asymmetric cluster partition may need more than one iteration to heal completely. Therefore, ensure that autoheal kicks in when only part of the partition has been healed.
keynslug
force-pushed
the
fix/EEC-112/autoheal-asymm
branch
from
e9cf087 to
9c98202
Compare
keynslug
force-pushed
the
fix/EEC-112/autoheal-asymm
branch
from
9c98202 to
f93e5e2
Compare
thalesmg
reviewed
Dec 13, 2024
thalesmg
previously approved these changes
Dec 13, 2024
zmstone
reviewed
Dec 16, 2024
zmstone
reviewed
Dec 16, 2024
zmstone
reviewed
Dec 16, 2024
Specifically, do not perform autoheal in small steps because it may lead to cluster inconsistencies. Sometimes Mnesia decides that cluster partitions are healed too early, before coordinator has a chance to reboot all of the nodes that have been partitioned off the cluster.
zmstone
reviewed
Dec 18, 2024
zmstone
reviewed
Dec 18, 2024
Specifically, stop using locality as a sorting criterion and avoid deduplicating entries for better diagnostics.
zmstone
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-13693.