Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve concurrency handling #20

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

savonarola
Copy link
Collaborator

No description provided.

@savonarola savonarola force-pushed the 0409-fix-concurrency-issues branch from 5db98f5 to 5ac3426 Compare April 9, 2024 23:20
@savonarola savonarola marked this pull request as ready for review April 9, 2024 23:23
@savonarola
Copy link
Collaborator Author

@qzhuyan This is based on the discussions in previous PRs

c_src/main.c Show resolved Hide resolved
@@ -343,6 +361,13 @@ static int
erlfdb_load(ErlNifEnv* env, void** priv, ERL_NIF_TERM num_schedulers)
{
ErlFDBSt* st = (ErlFDBSt*) enif_alloc(sizeof(ErlFDBSt));
int key_create_ret;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, this tmp var key_create_ret is not needed.

@savonarola savonarola merged commit 72e7014 into emqx:dev Apr 11, 2024
7 checks passed
@savonarola savonarola deleted the 0409-fix-concurrency-issues branch April 11, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants