Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new feature: SCRAM is supported. And provide a demo to use SCRAM. #233

Merged
merged 10 commits into from
Jul 29, 2024
Merged

new feature: SCRAM is supported. And provide a demo to use SCRAM. #233

merged 10 commits into from
Jul 29, 2024

Conversation

wanghaEMQ
Copy link
Member

  • Integered mqtt tcp dialer with scram
  • Add encode/decode for msg of auth.
  • Support to parse property in auth msg.
  • Add demo for enhanced authentication.

wanghaEMQ added 9 commits July 26, 2024 02:23
@wanghaEMQ
* NEW [scram] NEW SCRAM library is imported.
433bc3c 
Signed-off-by: wanghaemq <[email protected]>
@wanghaEMQ
* NEW [scram] base64 library is imported.
b000ecd 
Signed-off-by: wanghaemq <[email protected]>
@wanghaEMQ
* NEW [codec[ Add codec and property parse for auth msg.
58c3f85 
Signed-off-by: wanghaemq <[email protected]>
@wanghaEMQ
* NEW [mqtt_tcp] Handle auth and scram msgs in mqtt tcp layer.
9e3ebeb 
Signed-off-by: wanghaemq <[email protected]>
@wanghaEMQ
* NEW [cmake] Add base64 and scram to cmake.
dd57c74 
Signed-off-by: wanghaemq <[email protected]>
@wanghaEMQ
* NEW [cmake] Update cmake to load ssl when scram is enabled.
589c25f 
Signed-off-by: wanghaemq <[email protected]>
@wanghaEMQ
* NEW [mqtt_tcp] Add option to enable/disable scram.
20033e0 
Signed-off-by: wanghaemq <[email protected]>
@wanghaEMQ
* FIX [demo] Fix some warnings in mqtt_client and mqttv5_client.
1d90ed6 
Signed-off-by: wanghaemq <[email protected]>
@wanghaEMQ
* NEW [demo] Add demo mqttv5_scram.c.
a42c8aa 
Signed-off-by: wanghaemq <[email protected]>
JaylinYu
JaylinYu previously approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@JaylinYu JaylinYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty completed.
I will have a deep look now

CMakeLists.txt Outdated Show resolved Hide resolved
include/nng/supplemental/nanolib/base64.h Show resolved Hide resolved
src/mqtt/transport/tcp/mqtt_tcp.c Show resolved Hide resolved
@JaylinYu
Copy link
Member

remember tls!

@JaylinYu JaylinYu merged commit 32a148e into main Jul 29, 2024
13 of 14 checks passed
@JaylinYu JaylinYu deleted the wangha/dev3 branch July 29, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StargazerWayne StargazerWayne StargazerWayne left review comments

@JaylinYu JaylinYu JaylinYu approved these changes

@RanMaoyi RanMaoyi Awaiting requested review from RanMaoyi

@xinyi-xs xinyi-xs Awaiting requested review from xinyi-xs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wanghaEMQ @JaylinYu @StargazerWayne