Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support build with demo. Merge mqttv311 protocol layer with mqttv5. Support debug mode. #225

Merged
merged 9 commits into from
Mar 29, 2024
Merged

Support build with demo. Merge mqttv311 protocol layer with mqttv5. Support debug mode. #225

merged 9 commits into from
Mar 29, 2024

Conversation

wanghaEMQ
Copy link
Member

  • Support build with demo
  • Merge mqttv311 protocol layer with mqttv5.
  • Support debug (asan&tsan) mode.

@wanghaEMQ
* NEW [mqtt/proto] Merge mqtt protocol layer with mqtt v5 protocol la…
832ab59 
…yer.

Signed-off-by: wanghaemq <[email protected]>
@wanghaEMQ
* NEW [cmake] Support debug flag to enable debug mode.
ce6b582 
Signed-off-by: wanghaemq <[email protected]>
@wanghaEMQ
* ADD [demo] Add debug and asan cmake option for mqtt and mqttv5 clei…
925d57d 
…nt demo.

Signed-off-by: wanghaemq <[email protected]>
@wanghaEMQ
* FIX [mqtt/proto] Move pipe_recv into guard of lock when pipe_start.
2a9bed8 
Signed-off-by: wanghaemq <[email protected]>
@wanghaEMQ
* NEW [cmake] Add build_demo cmake option.
85fa1b8 
Signed-off-by: wanghaemq <[email protected]>
@wanghaEMQ
* NEW [cmake] Update the cmake_minimum_required. & Add debug and asan…
df284a1 
… for demos.

Signed-off-by: wanghaemq <[email protected]>
@wanghaEMQ
* FIX [demo/cmake] Fix the cmake error when build independently.
6a417d9 
Signed-off-by: wanghaemq <[email protected]>
@wanghaEMQ
Copy link
Member Author

[TBD] Docs update.

@codecov Codecov
Copy link

codecov bot commented Mar 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 82 lines in your changes are missing coverage. Please review.

Project coverage is 59.98%. Comparing base (67a259d) to head (865f3e5).

Files Patch % Lines
src/mqtt/protocol/mqtt/mqtt_client.c 0.00% 82 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
+ Coverage   59.10%   59.98%   +0.87%     
==========================================
  Files         103      102       -1     
  Lines       27539    27106     -433     
==========================================
- Hits        16277    16259      -18     
+ Misses      11262    10847     -415

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JaylinYu
JaylinYu approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@JaylinYu JaylinYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done

src/mqtt/protocol/mqtt/mqtt_client.c Show resolved Hide resolved
src/mqtt/protocol/mqtt/mqtt_client.c Show resolved Hide resolved
src/mqtt/protocol/mqtt/mqtt_client.c Show resolved Hide resolved
src/mqtt/protocol/mqtt/mqtt_client.c Show resolved Hide resolved
@JaylinYu JaylinYu mentioned this pull request Mar 29, 2024
Closed
@wanghaEMQ wanghaEMQ merged commit e5516c1 into main Mar 29, 2024
14 of 16 checks passed
@wanghaEMQ wanghaEMQ deleted the wangha/dev branch March 29, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinyi-xs xinyi-xs xinyi-xs approved these changes

@JaylinYu JaylinYu JaylinYu approved these changes

@StargazerWayne StargazerWayne Awaiting requested review from StargazerWayne

@RanMaoyi RanMaoyi Awaiting requested review from RanMaoyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wanghaEMQ @JaylinYu @xinyi-xs