Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better output directory for public files in build #315

Merged

Conversation

CachedaCodes
Copy link
Contributor

Motivation and context

Public files where copied to dist regardless of the actual output directory in the build. This PR changes it to take the actual directory.

  • Dependencies. If any, specify:
  • Open issue. If applicable, link:

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Change the output and run the build, favicon and snippet config file should be in the actual output directory.

@CachedaCodes CachedaCodes requested a review from a team as a code owner September 13, 2023 10:37
Copy link
Contributor

@herrardo herrardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CachedaCodes CachedaCodes merged commit d324d1d into main Sep 13, 2023
2 checks passed
@CachedaCodes CachedaCodes deleted the feature/better-output-directory-for-public-files-in-build branch September 13, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants