Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linguist exclude ipynb files and add Edward Molter to contributors #2

Merged
merged 1 commit into from
Sep 17, 2024
Merged

linguist exclude ipynb files and add Edward Molter to contributors #2

merged 1 commit into from
Sep 17, 2024

Conversation

emolter
Copy link
Owner

@emolter emolter commented Sep 17, 2024

Resolves JP-nnnn

Closes #

This PR addresses ...

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
  • Does this PR change user-facing code / API?
    • add an entry to CHANGES.rst within the relevant release section (otherwise add the no-changelog-entry-needed label to this PR)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@emolter emolter merged commit cdc2dfc into master Sep 17, 2024
12 of 13 checks passed
emolter pushed a commit that referenced this pull request Nov 22, 2024
@hayescr
Merge pull request #2 from drlaw1558/drl_combine1d
abe14d0 
Add median filtering to background spectrum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emolter