-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Word
content type
#181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit dealing with the addition of the Word
content type seems ok to me.
Ok, so I did some more proper testing and the issue described in #76 still manifests, but with a slightly different error message. Command:
Error:
Note, that I had to manually remove non-ASCII symbols from the downloaded dic/cif files to temporarily circumvent issue #182. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment #181 (comment).
It seems to me the issue is still the same - the concept cannot be found. I'll check a bit locally as well (didn't do this, just updated the ontology 😅 ). |
As a note, I managed to make this work locally. I had to also manually revert non-ASCII characters in Furthermore, I've implemented a However, this will not work properly until #182 has been fixed, so I'd consider this PR blocked by that issue. The newly generated CIF Core ontology can be found here. |
Fixes #182 Generate and update `cif-core.ttl` under ontologies.
Version 4.4.6 of PyCIFRW resolves the Unicode issue (thanks @jamesrhester), however, the issue with If it works properly for @CasperWA, this might just be an issue with me running things incorrectly. Commands I use in a new virtual environment with a fresh checkout of
|
You should run EDIT: Also, to ensure you're not reusing any manually edited dependency CIF and dic files, you should remove any locally downloaded |
@CasperWA Yes, as I have mentioned in my earlier comment (#181 (comment)), the command with |
Ah - it's not the new intended approach, it is merely a way to use the local version of the DDL ontology, which has the Sorry for the confusion. The |
Have not gotten any response from @emanueleghedini. Will merge this, as it fixes CI workflows and will instead open an issue to follow-up the ontology consistency. |
Closes #76
Adds
Word
in a similar fashion asCode
and similar.When storing the Turtle file (
cif-ddl.ttl
) from Protégé it changed the formatting. In order to understand the actual change(s), I have split it up into several commits.To see the purely formatting changes, see a34fd90.
To see the addition of
Word
, see d47bf00.Fixes #182 by enforcing at minimum v4.4.6 of PyCIFRW.
This PR goes a small step further and updates the
cif-core.ttl
file underontologies/
to the latest generated version of the CIF-ontology according to the updated cif_core.dic in COMCIFS and the newly addedWord
content type.Note, since the
Word
content type concept has not yet been approved by @emanueleghedini I'd not consider the generated version of the CIF-ontology 100 % accurate (yet).