Build for arm64 as well as amd64 #1066
Conversation
|
I'm guessing this doubles the build time. Can we use a build matrix to target simultaneously? |
jellybob
force-pushed
the
build-arm64-images
branch
2 times, most recently
from
ee3b27d to
e6a10c8
Compare
|
This might be doing a matrix build, assuming I've properly read the Github Actions docs. I've got no idea how to actually test it since builds only happen for |
|
Looks right to me! |
One important-ish note for testing: it's probably best to change the image tags from Because this branch/PR are opened from within (I say this as someone who generally tests GHA changes by hackily making changes from a repository |
This was a result of a misunderstanding on my behalf, I think: the deployment workflow uploads the container image(s) to Docker Hub, so the presence of an ARM64 image in addition to existing images shouldn't cause any problems, I suppose? (if so: no need for the image tag rename, after all) @jellybob had you seen / are you following along with postgis/docker-postgis#256? |
jellybob
force-pushed
the
build-arm64-images
branch
from
e6a10c8 to
e0a427b
Compare
In an ideal world this would be resolved by having the base image built for ARM as well as amd64, but without ARM runners for GitHub Actions this is infeasibly slow (I aborted a test build after 30 minutes - it takes less than a minute to do a build on my M1 Pro laptop).
jellybob
force-pushed
the
build-arm64-images
branch
from
2c24ac2 to
43626b5
Compare
|
Closing until Github Actions has ARM runners, at which point I'll take another pass at this. |
I'm not sure whether this actually works or not, but theoretically it should result in making arm64 images available for people running on recent Apple machines rather than having to translate from amd64 which sucks up battery life at an impressive rate.
Annoyingly this isn't a complete solution as PostGIS doesn't have ARM builds on Docker Hub, but it does get us most of the way there I believe.