Improve signer keypair generation #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typo and add newline to existing messages.
* signer: build signer executable * test: check signer operation * all: creates executable and runs test * clean: removes executables and object files * keys.txt: generate a new key pair * keys.sh: create shell script to set generated keys
now the default target. Added new keys.c target to describe how to update the public key in the badge firmware. Removed keys.txt dependency on signer to prevent regeneration of keys whenever you rebuild the executable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make it a bit easier to setup a new MCP instance by proving a Makefile to build the signer code and create a new key pair. The makefile also provides some targets to assist with using this new key with the MCP and Tilda firmware.